On Thu, Feb 15, 2018 at 9:42 PM, Colin King [off-list ref] wrote:

From: Colin Ian King <redacted>

The checks to see if key->dst.s6_addr and key->src.s6_addr are null
pointers are redundant because these are constant size arrays and
so the checks always return true.  Fix this by removing the redundant
checks.

+               for (i = 0; i < 4; i++)

+                       filter->f.mask.tcp_spec.dst_ip[i] |=
                                                        cpu_to_be32(0xffffffff);

Can it be one line then?

+               memcpy(&filter->f.data.tcp_spec.dst_ip,
+                      &key->dst.s6_addr32,

Ditto.

+                      sizeof(filter->f.data.tcp_spec.dst_ip));
+
+               for (i = 0; i < 4; i++)

+                       filter->f.mask.tcp_spec.src_ip[i] |=
                                                        cpu_to_be32(0xffffffff);

Ditto.

+               memcpy(&filter->f.data.tcp_spec.src_ip,
+                      &key->src.s6_addr32,

Ditto.

+                      sizeof(filter->f.data.tcp_spec.src_ip));

-- 
With Best Regards,
Andy Shevchenko