Thread (62 messages) 62 messages, 9 authors, 2017-12-19

Re: [PATCH v3 04/33] nds32: Kernel booting and initialization

From: Greentime Hu <hidden>
Date: 2017-12-08 13:26:33
Also in: linux-arch, linux-devicetree, linux-serial, lkml

Hi, Philippe:

2017-12-08 21:19 GMT+08:00 Philippe Ombredanne [off-list ref]:
Dear Greentime,

On Fri, Dec 8, 2017 at 10:11 AM, Greentime Hu [off-list ref] wrote:
quoted
From: Greentime Hu <redacted>

This patch includes the kernel startup code. It can get dtb pointer
passed from bootloader. It will create a temp mapping by tlb
instructions at beginning and goto start_kernel.

Signed-off-by: Vincent Chen <redacted>
Signed-off-by: Greentime Hu <redacted>
[]
quoted
--- /dev/null
+++ b/arch/nds32/kernel/head.S
@@ -0,0 +1,202 @@
+/*
+ * Copyright (C) 2005-2017 Andes Technology Corporation
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */

Have you considered using the new SPDX ids instead of this fine legalese?
e.g.:

// SPDX-License-Identifier: GPL-2.0
// Copyright (C) 2005-2017 Andes Technology Corporation

This is much shorter and neater (unless you are a legalese lover of course!)

Check also Thomas doc patches and Linus comments on why he prefers the
C++ comment style for these.
Thanks for your suggestions. We'd like to do this change.
I will apply it in the next version patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help