Thread (92 messages) 92 messages, 13 authors, 2017-12-08

Re: [PATCH v2 06/35] nds32: MMU fault handling and page table management

From: Al Viro <viro@ZenIV.linux.org.uk>
Date: 2017-12-07 16:40:55
Also in: linux-arch, linux-devicetree, linux-serial, lkml

On Mon, Nov 27, 2017 at 08:27:53PM +0800, Greentime Hu wrote:
+void do_page_fault(unsigned long entry, unsigned long addr,
+		   unsigned int error_code, struct pt_regs *regs)
[snip]
+	/*
+	 * If we're in an interrupt or have no user
+	 * context, we must not take the fault..
+	 */
+	if (unlikely(in_atomic() || !mm))
Broken.  in_atomic() is wrong here - it should be faulthandler_disabled().
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help