Thread (92 messages) 92 messages, 13 authors, 2017-12-08

Re: [PATCH v2 22/35] nds32: Device tree support

From: Greentime Hu <hidden>
Date: 2017-11-28 06:55:36
Also in: linux-arch, linux-devicetree, linux-serial, lkml

2017-11-27 22:30 GMT+08:00 Arnd Bergmann [off-list ref]:
On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu [off-list ref] wrote:
quoted
@@ -0,0 +1,55 @@
+/dts-v1/;
+/ {
+       compatible = "nds32 ae3xx";
The compatible string doesn't seem to match the binding, it should always have
vendor prefix.
Sorry I forgot to check this.
I will provide a document in bindings like
"Documentation/devicetree/bindings/nds32/andestech-boards".

quoted
+       #address-cells = <1>;
+       #size-cells = <1>;
+       interrupt-parent = <&intc>;
+
+       chosen {
+               bootargs = "earlycon console=ttyS0,38400n8 debug loglevel=7";
+               stdout-path = &serial0;
+       };
I would drop the bootargs here, this is something that should be set by the
bootloader and is up to the user.
Thanks
I will drop it in the next version patch.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help