Re: [PATCH 02/10] net: bcmgenet: free netdev on of_match_node() error
flat view
From: Doug Berger <opendmb@gmail.com>
Date: 2017-12-05 01:13:58
Also in:
linux-arm-kernel, lkml
On 12/02/2017 11:26 AM, Arvind Yadav wrote:
quoted hunk ↗ jump to hunk
The change is to call free_netdev(), If of_match_node() will fail. Signed-off-by: Arvind Yadav <redacted> --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index e2f1268..e0a8f79 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c@@ -3363,8 +3363,10 @@ static int bcmgenet_probe(struct platform_device *pdev) if (dn) { of_id = of_match_node(bcmgenet_match, dn); - if (!of_id) - return -EINVAL; + if (!of_id) { + err = -EINVAL; + goto err; + } } priv = netdev_priv(dev);
I agree with the fix if you want to resubmit separate from this series
and please include a "fixes" tag.
Thanks,
Doug