Thread (22 messages) 22 messages, 5 authors, 2017-12-05

Re: [PATCH 07/10] net: ethernet: smsc: Handle return value of platform_get_irq

flat view

From: Sergei Shtylyov <hidden>
Date: 2017-12-02 20:07:01
Also in: linux-arm-kernel, lkml

On 12/02/2017 10:26 PM, Arvind Yadav wrote:
quoted hunk ↗ jump to hunk
platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <redacted>
---
  drivers/net/ethernet/smsc/smc911x.c | 5 +++++
  1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c
index 0515744..a1cf18c 100644
--- a/drivers/net/ethernet/smsc/smc911x.c
+++ b/drivers/net/ethernet/smsc/smc911x.c
@@ -2088,6 +2088,11 @@ static int smc911x_drv_probe(struct platform_device *pdev)
  
  	ndev->dma = (unsigned char)-1;
  	ndev->irq = platform_get_irq(pdev, 0);
+	if (ndev->irq <= 0) {
+		ret = ndev->irq ? ndev->irq : -ENODEV;
   Same comments as the next patch...
quoted hunk ↗ jump to hunk
+		goto release_both;
+	}
+
  	lp = netdev_priv(ndev);
  	lp->netdev = ndev;
  #ifdef SMC_DYNAMIC_BUS_CONFIG
MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help