Thread (19 messages) 19 messages, 7 authors, 2017-12-02

Re: [PATCH net] net: phylink: fix link state on phy-connect

From: Andrew Lunn <andrew@lunn.ch>
Date: 2017-11-28 13:56:17
Also in: lkml

+	/* On _disconnect, the phy state machine and phylink resolve
+	 * are stopped before executing full gracefull down/reset state.
+	 * The further _connect starts with incorrect init state. Let's set
+	 * init values here.
+	 */
+	pl->phy_state.link = false;
+	pl->link_config.pause = MLO_PAUSE_AN;
+	pl->link_config.speed = SPEED_UNKNOWN;
+	pl->link_config.duplex = DUPLEX_UNKNOWN;
Hi Antoine

Looks sensible. My only comment would be, maybe it makes sense to
reduce the duplication by adding a little helper which is called here,
and in phylink_create()?

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help