Re: [PATCH v4 12/18] nfnetlink_gueue: exit_net cleanup check added

On 2017-11-12 11:52, Florian Westphal wrote:

Vasily Averin [off-list ref] wrote:

quoted

Be sure that instance_table array initialized in net_init hook
was return to initial state.

quoted

+	for (i = 0; i < INSTANCE_BUCKETS; i++)
+		if (WARN_ON_ONCE(!hlist_empty(&q->instance_table[i])))
+			break;

This looks strange, why if/break?

I did not want to generate huge number of messages on each non-empty hash bucket.

Plain WARN_ON_ONCE should be enough, but thats a nit so:

Oh, you're right.
In first patch version WARN_ON  was used here.
I've missed that only first message will be printed with _ONCE check.

Acked-by: Florian Westphal <fw@strlen.de>