Re: [PATCH v4 12/18] nfnetlink_gueue: exit_net cleanup check added

Vasily Averin [off-list ref] wrote:

Be sure that instance_table array initialized in net_init hook
was return to initial state.

+	for (i = 0; i < INSTANCE_BUCKETS; i++)
+		if (WARN_ON_ONCE(!hlist_empty(&q->instance_table[i])))
+			break;

This looks strange, why if/break?

Plain WARN_ON_ONCE should be enough, but thats a nit so:

Acked-by: Florian Westphal <fw@strlen.de>