Re: [PATCH v2 09/21] clusterip: exit_net cleanup check added

Hi Vasily,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on v4.14-rc8 next-20171106]
[cannot apply to net-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vasily-Averin/exit_net-checks-for-objects-initialized-in-net_init-hook/20171107-094512
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All error/warnings (new ones prefixed by >>):

   In file included from ./arch/xtensa/include/generated/asm/bug.h:1:0,
                    from include/linux/bug.h:5,
                    from include/linux/thread_info.h:12,
                    from include/asm-generic/preempt.h:5,
                    from ./arch/xtensa/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:81,
                    from include/linux/spinlock.h:51,
                    from include/linux/seqlock.h:36,
                    from include/linux/time.h:6,
                    from include/linux/stat.h:19,
                    from include/linux/module.h:10,
                    from net/ipv4//netfilter/ipt_CLUSTERIP.c:13:
   net/ipv4//netfilter/ipt_CLUSTERIP.c: In function 'clusterip_net_exit':

quoted

net/ipv4//netfilter/ipt_CLUSTERIP.c:823:40: error: expected ')' before 'i'

          "%s: configs list is not empty\n"i, __func__);
                                           ^
   include/asm-generic/bug.h:89:69: note: in definition of macro '__WARN_printf'
    #define __WARN_printf(arg...) warn_slowpath_fmt(__FILE__, __LINE__, arg)
                                                                        ^

quoted

net/ipv4//netfilter/ipt_CLUSTERIP.c:822:2: note: in expansion of macro 'WARN'

     WARN(!list_empty(&cn->configs),
     ^

quoted

net/ipv4//netfilter/ipt_CLUSTERIP.c:823:40: warning: format '%s' expects a matching 'char *' argument [-Wformat=]

          "%s: configs list is not empty\n"i, __func__);
                                           ^
   include/asm-generic/bug.h:89:69: note: in definition of macro '__WARN_printf'
    #define __WARN_printf(arg...) warn_slowpath_fmt(__FILE__, __LINE__, arg)
                                                                        ^

quoted

net/ipv4//netfilter/ipt_CLUSTERIP.c:822:2: note: in expansion of macro 'WARN'

     WARN(!list_empty(&cn->configs),
     ^

vim +823 net/ipv4//netfilter/ipt_CLUSTERIP.c

   813	
   814	static void clusterip_net_exit(struct net *net)
   815	{
   816	#ifdef CONFIG_PROC_FS
   817		struct clusterip_net *cn = net_generic(net, clusterip_net_id);
   818		proc_remove(cn->procdir);
   819		cn->procdir = NULL;
   820	#endif
   821		nf_unregister_net_hook(net, &cip_arp_ops);
 > 822		WARN(!list_empty(&cn->configs),
 > 823		     "%s: configs list is not empty\n"i, __func__);
   824	}
   825	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation