Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

From
Corentin Labbe <clabbe.montjoie@gmail.com>
Date
2017-09-08 14:28:36
Also in
linux-arm-kernel, linux-devicetree, lkml
Reply to
Andrew Lunn, 2017-09-08
On Fri, Sep 08, 2017 at 04:17:36PM +0200, Andrew Lunn wrote:
quoted
quoted
Do you know why the reset times out/fails?
Because there are nothing connected to it.
That should not be an issue. A read should just return 0xffff.  And it
should return 0xffff fast. The timing of the MDIO protocol is fixed. A
read or a write takes a fixed number of cycles, independent of if
there is a device there or not. The bus data line has a pullup, so if
you try to access a missing device, you automatically read 0xffff.
Perhaps, but the reality is that with nothing connected to it, the reset of the MAC timeout.
Certainly, the MAC does not support finding no PHY.

So, to prevent an error message, and a "freeze" of the net process, the need_reset trick is necessary.

Regards
Corentin Labbe
Thread (35 messages) 35 messages, 5 authors, last reply 2017-09-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help