Thread (13 messages) 13 messages, 2 authors, 2017-09-01

Re: [PATCH 0/5] net: mdio-mux: Misc fix

flat view

From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: 2017-09-01 08:30:26
Also in: lkml

On Wed, Aug 30, 2017 at 09:01:19PM +0200, Andrew Lunn wrote:
On Wed, Aug 30, 2017 at 07:46:46PM +0200, Corentin Labbe wrote:
quoted
Hello

This patch series fix minor problems found when working on the
dwmac-sun8i syscon mdio-mux.
Hi Corentin

In geineral, a nice patchset.
Thanks, I will send a v2 with your suggestions.
Looking at the code, there are a few calls to devm_kfree() which look
redundant. This one should probably stay:

	   	if (r) {
			mdiobus_free(cb->mii_bus);
			devm_kfree(dev, cb);
		} else {

but i think the others can go.

Just a suggestion, not a problem if you don't feel like doing this...
I will try but in another serie. For letting more time for test.

Regards
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help