Thread (13 messages) 13 messages, 2 authors, 2017-09-01

Re: [PATCH 0/5] net: mdio-mux: Misc fix

flat view

From: Andrew Lunn <andrew@lunn.ch>
Date: 2017-08-30 19:01:23
Also in: lkml

On Wed, Aug 30, 2017 at 07:46:46PM +0200, Corentin Labbe wrote:
Hello

This patch series fix minor problems found when working on the
dwmac-sun8i syscon mdio-mux.
Hi Corentin

In general, a nice patchset.

Looking at the code, there are a few calls to devm_kfree() which look
redundant. This one should probably stay:

	   	if (r) {
			mdiobus_free(cb->mii_bus);
			devm_kfree(dev, cb);
		} else {

but i think the others can go.

Just a suggestion, not a problem if you don't feel like doing this...

   Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help