Thread (47 messages) 47 messages, 13 authors, 2017-07-18

Re: [PATCH 20/22] sound: pci: avoid string overflow warnings

From: Arnd Bergmann <arnd@arndb.de>
Date: 2017-07-18 11:52:33
Also in: alsa-devel, linux-scsi, lkml

On Fri, Jul 14, 2017 at 2:28 PM, Takashi Iwai [off-list ref] wrote:
On Fri, 14 Jul 2017 14:07:12 +0200,

Thanks for the patch.  I have seen it but ignored, so far, as not sure
which action is the best.  An alternative solution is to use
snprintf() blindly, for example.

For mixart, it's even better to drop mgr->shortname[] and longname[]
assignment.  The shortname is the fixed string, and the longname is
used only at copying to card->longname, so we can create a string
there from the scratch.
I've done that now, and tried to be a little smarter with the other
conversions. I also found related problems in ISA drivers after
randconfig testing and fixed those as well.

Sent a 7-patch series now as a replacement.

       Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help