Re: [PATCH 12/22] vmxnet3: avoid format strint overflow warning
From: David Miller <davem@davemloft.net>
Date: 2017-07-14 16:04:17
Also in:
linux-scsi, lkml
From: David Miller <davem@davemloft.net>
Date: 2017-07-14 16:04:17
Also in:
linux-scsi, lkml
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 14 Jul 2017 14:07:04 +0200
gcc-7 notices that "-event-%d" could be more than 11 characters long
if we had larger 'vector' numbers:
drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_activate_dev':
drivers/net/vmxnet3/vmxnet3_drv.c:2095:40: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=]
sprintf(intr->event_msi_vector_name, "%s-event-%d",
^~~~~~~~~~~~~
drivers/net/vmxnet3/vmxnet3_drv.c:2095:3: note: 'sprintf' output between 9 and 33 bytes into a destination of size 32
The current code is safe, but making the string a little longer
is harmless and lets gcc see that it's ok.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>Applied.