RE: [PATCH 04/22] scsi: fusion: fix string overflow warning
From: David Laight <hidden>
Date: 2017-07-17 09:17:53
Also in:
linux-scsi, lkml
From: David Laight <hidden>
Date: 2017-07-17 09:17:53
Also in:
linux-scsi, lkml
From: Arnd Bergmann
Sent: 14 July 2017 13:07
gcc points out a theorerical string overflow:
drivers/message/fusion/mptbase.c: In function 'mpt_detach':
drivers/message/fusion/mptbase.c:2103:17: error: '%s' directive writing up to 31 bytes into a region
of size 28 [-Werror=format-overflow=]
sprintf(pname, MPT_PROCFS_MPTBASEDIR "/%s/summary", ioc->name);
^~~~~
drivers/message/fusion/mptbase.c:2103:2: note: 'sprintf' output between 13 and 44 bytes into a
destination of size 32
We can simply double the size of the local buffer here to be on the
safe side.I think I'd change it to snprintf() as well. Saves any worries if ioc->name isn't '\0' terminated. David