Re: [PATCH nf v2 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

On 03/20/2017 01:15 PM, Feng Gao wrote:

quoted

quoted

From: Gao Feng <redacted>

In the commit <93557f53e1fb> ("netfilter: nf_conntrack: nf_conntrack snmp

   Angle brackets not needed. :-)
   The commit citing style is the same as for the Fixes: tag.

The checkpatch.pl reports the following error, if remove the angle brackets.

    Because it stops recognizing the commit ID! :-)

ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit fatal: ambig ("evision or path
not in the working tree.")'

    So check the patch in the correct tree because that seems to be the 
problem... Angle brackets are surely not required.

#7:
In the commit 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp

total: 1 errors, 0 warnings, 0 checks, 27 lines checked


Regards
Feng

[...]

MBR, Sergei