Re: [PATCH nf v2 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register
From: Sergei Shtylyov <hidden>
Date: 2017-03-20 10:09:28
Also in:
netfilter-devel
On 3/20/2017 12:55 PM, fgao@ikuai8.com wrote:
From: Gao Feng <redacted>
In the commit <93557f53e1fb> ("netfilter: nf_conntrack: nf_conntrack snmp
Angle brackets not needed. :-)
The commit citing style is the same as for the Fixes: tag.
helper"), the snmp_helper is replaced by nf_nat_snmp_hook. So the
snmp_helper is never registered. But it still tries to unregister the
snmp_helper, it could cause the panic.
Now remove the useless snmp_helper and the unregister call in the
error handler.
Fixes: 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp helper")
Signed-off-by: Gao Feng <redacted>[...] MBR, Sergei