Re: [PATCH nf v2 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

On Mon, Mar 20, 2017 at 6:09 PM, Sergei Shtylyov
[off-list ref] wrote:

On 3/20/2017 12:55 PM, fgao@ikuai8.com wrote:

quoted

From: Gao Feng <redacted>

In the commit <93557f53e1fb> ("netfilter: nf_conntrack: nf_conntrack snmp

   Angle brackets not needed. :-)
   The commit citing style is the same as for the Fixes: tag.

The checkpatch.pl reports the following error, if remove the angle brackets.

ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit fatal: ambig ("evision or path
not in the working tree.")'
#7:
In the commit 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp

total: 1 errors, 0 warnings, 0 checks, 27 lines checked


Regards
Feng

quoted

helper"), the snmp_helper is replaced by nf_nat_snmp_hook. So the
snmp_helper is never registered. But it still tries to unregister the
snmp_helper, it could cause the panic.

Now remove the useless snmp_helper and the unregister call in the
error handler.

Fixes: 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp helper")

Signed-off-by: Gao Feng <redacted>

[...]

MBR, Sergei