Re: [PATCH v4 01/10] ethernet: add sun8i-emac driver
flat view
From: Rami Rosen <hidden>
Date: 2016-10-23 12:09:00
Also in:
linux-arm-kernel, linux-devicetree, lkml
Hi Corentin, Trivial comment: rx_saf_fai and rx_daf_fail are not used. This implies that also rx_saf_error and rx_daf_error should be removed:
+static const char const estats_str[][ETH_GSTRING_LEN] = {...
quoted hunk ↗ jump to hunk
+ "rx_header_error", + "rx_overflow_error", + "rx_saf_error", + "rx_daf_error", + "rx_buf_error",
...
quoted hunk ↗ jump to hunk
+ +struct sun8i_emac_stats { + u64 rx_payload_error;
...
quoted hunk ↗ jump to hunk
+ u64 rx_overflow_error; + u64 rx_saf_fail; + u64 rx_daf_fail;
quoted hunk ↗ jump to hunk
+ u64 tx_used_desc; + u64 napi_schedule; + u64 napi_underflow; +}; +
Trivial: typo, should be: can transfer
+/* The datasheet said that each descriptor can transfers up to 4096bytes + * But latter, a register documentation reduce that value to 2048
Regards, Rami Rosen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html