Re: [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon control module
From: Maxime Ripard <hidden>
Date: 2016-10-11 09:51:26
Also in:
linux-arm-kernel, linux-devicetree, lkml
On Mon, Oct 10, 2016 at 02:50:21PM +0200, Jean-Francois Moine wrote:
On Mon, 10 Oct 2016 14:31:51 +0200 Maxime Ripard [off-list ref] wrote:quoted
Hi, On Fri, Oct 07, 2016 at 10:25:51AM +0200, Corentin Labbe wrote:quoted
This patch add the dt node for the syscon register present on the Allwinner H3. Only two register are present in this syscon and the only one useful is the one dedicated to EMAC clock. Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- arch/arm/boot/dts/sun8i-h3.dtsi | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi index 8a95e36..1101d2f 100644 --- a/arch/arm/boot/dts/sun8i-h3.dtsi +++ b/arch/arm/boot/dts/sun8i-h3.dtsi@@ -140,6 +140,11 @@ #size-cells = <1>; ranges; + syscon: syscon@01c00000 { + compatible = "syscon";It would be great to have a more specific compatible here in addition to the syscon, like "allwinner,sun8i-h3-system-controller".The System Control area is just like the PRCM area: it would be simpler to define the specific registers in the associated drivers.
Until you actually have to share those registers between different devices, and then you're just screwed. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com