Re: [PATCH v4 01/10] ethernet: add sun8i-emac driver
From: Joe Perches <joe@perches.com>
Date: 2016-10-07 15:02:59
Also in:
linux-arm-kernel, linux-devicetree, lkml
On Fri, 2016-10-07 at 10:25 +0200, Corentin Labbe wrote:
This patch add support for sun8i-emac ethernet MAC hardware. It could be found in Allwinner H3/A83T/A64 SoCs.
trivial notes:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/allwinner/sun8i-emac.c b/drivers/net/ethernet/allwinner/sun8i-emac.c
[]
+static const char const estats_str[][ETH_GSTRING_LEN] = {one too many const
+/* MAGIC value for knowing if a descriptor is available or not */ +#define DCLEAN cpu_to_le32(BIT(16) | BIT(14) | BIT(12) | BIT(10) | BIT(9))
Aren't there #defines for these bits?
+static void sun8i_emac_flow_ctrl(struct sun8i_emac_priv *priv, int duplex,
+ int fc)
+{
+ u32 flow = 0;
+
+ flow = readl(priv->base + EMAC_RX_CTL0);
+ if (fc & EMAC_FLOW_RX)
+ flow |= BIT(16);
+ else
+ flow &= ~BIT(16);
+ writel(flow, priv->base + EMAC_RX_CTL0);
+
+ flow = readl(priv->base + EMAC_TX_FLOW_CTL);
+ if (fc & EMAC_FLOW_TX)
+ flow |= BIT(0);
+ else
+ flow &= ~BIT(0);more magic bits that could be #defines
+static int sun8i_emac_rx_from_ddesc(struct net_device *ndev, int i)
+{
[]
+ /* the checksum or length of received frame's payload is wrong*/
+ if (dstatus & BIT(0)) {[]
+ if (dstatus & BIT(1)) {[]
+ if ((dstatus & BIT(3))) {etc...