Re: [PATCH net-next 6/6] net: use core MTU range checking in misc drivers

From
Stefan Richter <stefanr@s5r6.in-berlin.de>
Date
2016-10-22 18:52:29
Also in
linux-rdma, lkml
Reply to
Stefan Richter, 2016-10-22
On Oct 22 Stefan Richter wrote:
On Oct 19 Jarod Wilson wrote:
quoted
On Thu, Oct 20, 2016 at 12:38:46AM +0200, Stefan Richter wrote:  
quoted
On Oct 19 Sabrina Dubroca wrote:  
quoted
2016-10-18, 22:33:33 -0400, Jarod Wilson wrote:
[...]
quoted
quoted
quoted
quoted
@@ -1481,6 +1471,8 @@ static int fwnet_probe(struct fw_unit *unit,
 	max_mtu = (1 << (card->max_receive + 1))
 		  - sizeof(struct rfc2734_header) - IEEE1394_GASP_HDR_SIZE;
 	net->mtu = min(1500U, max_mtu);
+	net->min_mtu = ETH_MIN_MTU;
+	net->max_mtu = net->mtu;    
But that will now prevent increasing the MTU above the initial value?  
Indeed, therefore NAK.  
However, there's an explicit calculation for 'max_mtu' right there that I
glazed right over. It would seem perhaps *that* should be used for
net->max_mtu here, no?  
No.  This 'max_mtu' here is not the absolute maximum.  It is only an
initial MTU which has the property that link fragmentation is not
going to happen (if all other peers will at least as capable as this
node).
Besides, card->max_receive is about what the card can receive (at the IEEE
1394 link layer), not about what the card can send.
-- 
Stefan Richter
-======----- =-=- =-==-
http://arcgraph.de/sr/
Thread (63 messages) 63 messages, 15 authors, last reply 2016-10-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help