Re: [PATCH 3/5] ISDN-CAPI: Adjust 17 function calls together with variable assignments
flat view
From: Paul Bolle <hidden>
Date: 2016-09-26 09:13:03
Also in:
kernel-janitors, lkml
On Sun, 2016-09-25 at 13:13 +0200, SF Markus Elfring wrote:
The script "checkpatch.pl" can point out that assignments should usually not be performed within condition checks. Thus move the assignment for a variable to a separate statement in four functions.
Did you recycle this commit explanation? Because git diff tells me you actually touched about eight functions.
Signed-off-by: Markus Elfring <redacted> --- drivers/isdn/capi/capidrv.c | 59 +++++++++++++++++++++++++++------------------ 1 file changed, 36 insertions(+), 23 deletions(-)
So I ran checkpatch on this file, just like you did. Specifically, I did: scripts/checkpatch.pl -f drivers/isdn/capi/capidrv.c | grep "assignment in if condition" | wc -l It tells me there are actually 18 instances of this "ERROR". Why did you ignore one of it in this patch? Paul Bolle