Thread (13 messages) 13 messages, 3 authors, 2016-09-26

Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces

flat view

From: SF Markus Elfring <hidden>
Date: 2016-09-25 12:47:17
Also in: kernel-janitors, lkml

quoted
@@ -976,13 +974,12 @@ static void handle_controller(_cmsg *cmsg)
         if (debugmode)
             printk(KERN_DEBUG "capidrv-%d: listenconf Info=0x%4x (%s) cipmask=0x%x\n",
                    card->contrnr, cmsg->Info, capi_info2str(cmsg->Info), card->cipmask);
-        if (cmsg->Info) {
+        if (cmsg->Info)
             listen_change_state(card, EV_LISTEN_CONF_ERROR);
-        } else if (card->cipmask == 0) {
+        else if (card->cipmask == 0)
             listen_change_state(card, EV_LISTEN_CONF_EMPTY);
-        } else {
+             else
   Indented too much.
How do you think about an alignment of this "else"
with the corresponding if statement three lines above?

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help