[PATCH 1/5] ISDN-CAPI: Use kmalloc_array() in capidrv_addcontr()
flat view
STALE3673d
From: SF Markus Elfring <hidden>
Date: 2016-09-25 11:11:21
Also in:
kernel-janitors, lkml
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Markus Elfring <redacted> Date: Sun, 25 Sep 2016 11:06:17 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted> --- drivers/isdn/capi/capidrv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c
index 85cfa4f..cd8e1a6 100644
--- a/drivers/isdn/capi/capidrv.c
+++ b/drivers/isdn/capi/capidrv.c@@ -2268,7 +2268,9 @@ static int capidrv_addcontr(u16 contr, struct capi_profile *profp) strcpy(card->name, id); card->contrnr = contr; card->nbchan = profp->nbchannel; - card->bchans = kmalloc(sizeof(capidrv_bchan) * card->nbchan, GFP_ATOMIC); + card->bchans = kmalloc_array(card->nbchan, + sizeof(capidrv_bchan), + GFP_ATOMIC); if (!card->bchans) { printk(KERN_WARNING "capidrv: (%s) Could not allocate bchan-structs.\n", id);
--
2.10.0