Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

On Tue, Jun 28, 2016 at 3:43 PM, Joe Perches [off-list ref] wrote:

On Tue, 2016-06-28 at 15:34 -0400, Jon Mason wrote:

quoted

The bgmac_* print wrappers call dev_* prints with the dev pointer from
the bcma core.  In anticipation of removing the bcma requirement for
this driver, these must be changed to not reference that struct.  So,
simply change all of the bgmac_* prints to their dev_* counterparts.  In
some cases netdev_* prints are more appropriate, so change those as
well.

Thanks, but...

quoted

diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c

[]

quoted

@@ -1515,7 +1516,7 @@ static void bgmac_get_drvinfo(struct net_device *net_dev,
                            struct ethtool_drvinfo *info)
 {
      strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
-     strlcpy(info->bus_info, "BCMA", sizeof(info->bus_info));
+     strlcpy(info->bus_info, "AXI", sizeof(info->bus_info));
 }

Unrelated change?

This is a needed change, but unrelated to this patch.  I'll move it to
the 5/7 patch, where it more logically fits.

Thanks,
Jon