Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

On Wed, Jun 29, 2016 at 2:46 PM, Andrew Lunn [off-list ref] wrote:

On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote:

quoted

On 06/29/2016 07:13 AM, Andrew Lunn wrote:

quoted

Hi Jon

I know you are just refactoring code, but at some point it would be
good to take a closer look at this MDIO bus driver.

quoted

And, to re-iterate all of your points are valid, but this is premature

We agree then :-)

   Andrew

I also agree with all of your points, but hope this is not something
that would prevent this patch series from being acceptable.  It could
be quite an effort to try and properly document the code and what it
is doing, get HW to verify the assumptions from the documentation (as
the MIPS HW was done by a different group, no hardware is available,
etc), relocate the code to the drivers/net/phy and add a standard
interface.  From your original comment, I believe that you agree that
this additional effort is not necessary at this point in time.

Thanks,
Jon