Re: Micrel Phy KSZ8031 clock select setting in dts

On Mon, Jun 20, 2016 at 03:56:10PM +0300, Sergei Shtylyov wrote:

Hello.

On 6/20/2016 3:08 PM, Oliver Graute wrote:

quoted

thx you both for confirming that. Can you tell me also if the clock
statement s fine in my dts?

&fec1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_enet1>;
phy-mode = "rmii";
micrel,rmii-reference-clock-select-25-mhz;
clocks,rmii-ref;

   You need:

	clocks = <&your_clock>;
	clock-names = "rmii-ref";

With a clock node specified like:

	your_clock: rmii-ref {
		#clock-cells = <0>;
		compatible = "fixed-clock";
		clock-frequency = <50000000>;
	};

(assuming this is a fixed clock which can't be retrieved from elsewhere
in the clock tree)

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |