Thread (35 messages) flat view 35 messages, 3 authors, 2016-06-06

Re: [PATCH net-next 8/9] net: dsa: bcm_sf2: Make it a real platform device driver

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2016-06-05 22:30:32

Le 04/06/2016 13:55, Andrew Lunn a écrit :
quoted
-static struct dsa_switch_driver bcm_sf2_switch_driver = {
+static struct dsa_switch_driver bcm_sf2_switch_ops = {
 	.tag_protocol		= DSA_TAG_PROTO_BRCM,
 	.probe			= bcm_sf2_sw_drv_probe,
 	.setup			= bcm_sf2_sw_setup,
Does this also allow you to kill bcm_sf2_sw_drv_probe?

dsa2 will never call it, and now you have your old binding parsed by
the legacy code in dsa2, you might not need it at all.
Good point, yes, that can go away now, thanks!
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help