Re: [PATCH net-next 7/9] net: dsa: Initialize CPU port ethtool ops per tree

Le 04/06/2016 13:38, Andrew Lunn a écrit :

quoted

index e8386157de30..938262010524 100644

--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c

@@ -346,7 +346,7 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
 			continue;
 	}
 
-	return 0;
+	return dsa_cpu_port_ethtool_setup(dst, ds);

Hi Florian

This is wrong. Remember, multiple CPU ports. You need to apply this to
each CPU port.

We do not quite support that properly though, we still do not create a
"cpu" network device, and there is only a single master netdev per
dsa_switch at the moment, making the secondary CPU port interfaces
impossible to overlay their backing "master" netdev with their companion
switch port statistics at the moment.

This fixes a real bug where we end-up clobbering
dsa_cpu_port_ethtool_ops as soon as there are multiple trees being
registered, and this can now happen.
-- 
Florian