Thread (35 messages) flat view 35 messages, 3 authors, 2016-06-06

Re: [PATCH net-next 7/9] net: dsa: Initialize CPU port ethtool ops per tree

From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-06-04 20:38:57

quoted hunk ↗ jump to hunk
index e8386157de30..938262010524 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -346,7 +346,7 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
 			continue;
 	}
 
-	return 0;
+	return dsa_cpu_port_ethtool_setup(dst, ds);
Hi Florian

This is wrong. Remember, multiple CPU ports. You need to apply this to
each CPU port.

     Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help