Thread (50 messages) 50 messages, 9 authors, 2016-05-30

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-05-13 04:07:10
Also in: linux-devicetree, lkml

quoted
quoted
+	gpiod = fwnode_get_named_gpiod(&child->fwnode, "reset-gpios");
+	/* Deassert the reset signal */
+	if (!IS_ERR(gpiod))
+		gpiod_direction_output(gpiod, 0);
This is wrong I think. You must only ignore -ENODEV, all other error
   At least -ENOSYS should also be ignored (it's returned when
gpiolib is not configured), right? When does -ENODEV gets returned
(it's not easy to follow)?
quoted
codes should be passed to the caller.
   The caller doesn't care anyway...
It should do. What if fwnode_get_named_gpiod() returns -EPROBE_DEFER
because the GPIO driver has not been loaded yet?

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help