Le 12/04/2016 15:54, Sergei Shtylyov a écrit :

Hello.

On 4/12/2016 12:22 PM, Nicolas Ferre wrote:

quoted

quoted

quoted

With  the 'phylib' now  being aware of  the "reset-gpios" PHY node property,
there should be no need to frob the PHY reset in this  driver anymore...

Signed-off-by: Sergei Shtylyov <redacted>

---
  drivers/net/ethernet/cadence/macb.c |   17 -----------------
  drivers/net/ethernet/cadence/macb.h |    1 -
  2 files changed, 18 deletions(-)

Index: net-next/drivers/net/ethernet/cadence/macb.c
===================================================================

--- net-next.orig/drivers/net/ethernet/cadence/macb.c
+++ net-next/drivers/net/ethernet/cadence/macb.c

[...]

quoted

quoted

quoted

@@ -2977,18 +2976,6 @@ static int macb_probe(struct platform_de
  	else
  		macb_get_hwaddr(bp);

-	/* Power up the PHY if there is a GPIO reset */
-	phy_node =  of_get_next_available_child(np, NULL);
-	if (phy_node) {
-		int gpio = of_get_named_gpio(phy_node, "reset-gpios", 0);
-
-		if (gpio_is_valid(gpio)) {
-			bp->reset_gpio = gpio_to_desc(gpio);
-			gpiod_direction_output(bp->reset_gpio, 1);

Hi Sergei

The code you are deleting would of ignored the flags in the gpio

I don't parse this.

quoted

The code deleted does take the flag into account.

    Not really -- you need to call of_get_named_gpio_flags() (with a valid 
last argument) for that.

Yep,

quoted

And the DT property
associated to it seems correct to me (I mean, with proper flag
specification).

    It apparently is not as it have GPIO_ACTIVE_HIGH and the driver assumes 
active-low reset signal.

Yes, logic was inverted and... anyway, the flag never used for real...
Thanks Sergei.

No problem for me accepting a patch for the at91-vinco.dts.

Bye,
-- 
Nicolas Ferre