Re: [PATCH v2 net-next 3/5] net: vxlan: enable local checksum offload
From: Alexander Duyck <hidden>
Date: 2016-01-08 03:46:07
On Thu, Jan 7, 2016 at 9:12 AM, Edward Cree [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Edward Cree <redacted> --- drivers/net/vxlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 6369a57..d4acbc9 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c@@ -1733,7 +1733,7 @@ static int vxlan6_xmit_skb(struct dst_entry *dst, struct sock *sk, goto err; } - skb = iptunnel_handle_offloads(skb, udp_sum, type); + skb = iptunnel_handle_offloads(skb, false, type); if (IS_ERR(skb)) { err = -EINVAL; goto err;@@ -1814,7 +1814,7 @@ static int vxlan_xmit_skb(struct rtable *rt, struct sock *sk, struct sk_buff *sk if (WARN_ON(!skb)) return -ENOMEM; - skb = iptunnel_handle_offloads(skb, udp_sum, type); + skb = iptunnel_handle_offloads(skb, false, type); if (IS_ERR(skb)) return PTR_ERR(skb);
So I just tried testing your patches and as it turns out you are still missing some bits. In this patch for instance the calls to udp_tunnel_xmit_skb and udp_tunnel6_xmit skb need to be updated so that you pass false for the last parameter and allow the use of your udp_set_csum modifications. - Alex