Re: [PATCH v2 net-next 3/5] net: vxlan: enable local checksum offload
From: Alexander Duyck <hidden>
Date: 2016-01-08 00:15:23
On Thu, Jan 7, 2016 at 9:12 AM, Edward Cree [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Edward Cree <redacted> --- drivers/net/vxlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 6369a57..d4acbc9 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c@@ -1733,7 +1733,7 @@ static int vxlan6_xmit_skb(struct dst_entry *dst, struct sock *sk, goto err; }
A few lines up from here there is a "udp_sum = false" that can be dropped for the remote checksum stuff.
quoted hunk ↗ jump to hunk
- skb = iptunnel_handle_offloads(skb, udp_sum, type); + skb = iptunnel_handle_offloads(skb, false, type); if (IS_ERR(skb)) { err = -EINVAL; goto err;@@ -1814,7 +1814,7 @@ static int vxlan_xmit_skb(struct rtable *rt, struct sock *sk, struct sk_buff *sk if (WARN_ON(!skb)) return -ENOMEM;
Same thing for this one. If you aren't passing it there is no point in updating it a few lines above here.
- skb = iptunnel_handle_offloads(skb, udp_sum, type);
+ skb = iptunnel_handle_offloads(skb, false, type);
if (IS_ERR(skb))
return PTR_ERR(skb);