Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

On 08/17/2015 05:14 PM, Guenter Roeck wrote:

One nitpick I noticed after sending my patch: dev can never be NULL in
smsc911x_probe_config(), so it does not really make sense to check if it is NULL.

No, it doesn't... it should really be something like

if (dev_fwnode(dev))

But dev_fwnode is static inline in property.c, and i'm pretty sure that 
still isn't 100% correct.The best plan might just be to remove the 
check, and abort on failure to find the phy property per your patch.