Thread (14 messages) flat view 14 messages, 4 authors, 2015-08-26

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

From: David Miller <davem@davemloft.net>
Date: 2015-08-17 21:06:39
Also in: lkml

From: Guenter Roeck <linux@roeck-us.net>
Date: Mon, 17 Aug 2015 13:45:36 -0700
Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
the call to smsc911x_probe_config() unconditional, and no longer fails if
there is no device node. device_get_phy_mode() is called unconditionally,
and if there is no phy node configured returns an error code. This error
code is assigned to phy_interface, and interpreted elsewhere in the code
as valid phy mode. This in turn causes qemu to crash when running a
variant of realview_pb_defconfig.

	qemu: hardware error: lan9118_read: Bad reg 0x86

Fixes: 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT")
Cc: Jeremy Linton <redacted>
Cc Graeme Gregory [off-list ref]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help