Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver
From: Scott Wood <hidden>
Date: 2015-07-10 18:50:48
Also in:
linuxppc-dev, lkml
From: Scott Wood <hidden>
Date: 2015-07-10 18:50:48
Also in:
linuxppc-dev, lkml
On Fri, 2015-07-10 at 13:29 -0500, Pledge Roy-R01356 wrote:
quoted
return in_be32((void *)bm + offset);quoted
^ [...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’: [...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration of function ‘out_be32’ [-Werror=implicit-function-declaration] out_be32((void *)bm + offset, val);These PPCisms will need to be fixed. LS1043A is an ARM chip with DPAA 1.0.LS1043 (ARM, Little Endian) support is still work in progress. The patches for that are being tested now but are based on the SDK version of the driver and will need to be massaged in order to get them applied here. Our plan of record is to add upstream support for this at a later time.
If you're already reworking this for upstream acceptance, why not fix the more obvious PPCisms now? -Scott