Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

On Fri, 2015-07-10 at 10:38 +0200, Paul Bolle wrote:

On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:

quoted

--- /dev/null
+++ b/drivers/soc/fsl/qbman/Kconfig

@@ -0,0 +1,33 @@
+menuconfig FSL_DPA
+   bool "Freescale DPAA support"
+   depends on FSL_SOC || COMPILE_TEST

Are you sure about COMPILE_TEST?

quoted

+   default n
+   help
+           FSL Data-Path Acceleration Architecture drivers
+
+           These are not the actual Ethernet driver(s)
+
+if FSL_DPA

[...]

quoted

+config FSL_BMAN
+   tristate "BMan device management"
+   default n
+   help
+           FSL DPAA BMan driver
+
+endif # FSL_DPA

Because with FSL_BMAN set to 'm' testing things with
    make -C ../../../.. M=$PWD bman.ko    

will not actually compile on x86_64:

make: Entering directory '[...]'
  CC [M]  [...]/drivers/soc/fsl/qbman/bman.o
In file included from [...]/drivers/soc/fsl/qbman/bman_priv.h:33:0,
                 from [...]/drivers/soc/fsl/qbman/bman.c:31:
[...]/drivers/soc/fsl/qbman/dpaa_sys.h: In function ‘mfatb’:
[...]/drivers/soc/fsl/qbman/dpaa_sys.h:134:8: error: implicit declaration 
of function ‘mfspr’ [-Werror=implicit-function-declaration]
   hi = mfspr(SPRN_ATBU);
        ^
[...]/drivers/soc/fsl/qbman/dpaa_sys.h:134:14: error: ‘SPRN_ATBU’ 
undeclared (first use in this function)
   hi = mfspr(SPRN_ATBU);
              ^
[...]/drivers/soc/fsl/qbman/dpaa_sys.h:134:14: note: each undeclared 
identifier is reported only once for each function it appears in
[...]/drivers/soc/fsl/qbman/dpaa_sys.h:135:14: error: ‘SPRN_ATBL’ 
undeclared (first use in this function)
   lo = mfspr(SPRN_ATBL);
              ^
[...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_in’:
[...]/drivers/soc/fsl/qbman/bman.c:168:9: error: implicit declaration of 
function ‘in_be32’ [-Werror=implicit-function-declaration]
  return in_be32((void *)bm + offset);
         ^
[...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’:
[...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration of 
function ‘out_be32’ [-Werror=implicit-function-declaration]
  out_be32((void *)bm + offset, val);

These PPCisms will need to be fixed.  LS1043A is an ARM chip with DPAA 1.0.

  ^
[...]/drivers/soc/fsl/qbman/bman.c: In function ‘of_fsl_bman_probe’:
[...]/drivers/soc/fsl/qbman/bman.c:463:17: error: ‘NO_IRQ’ undeclared 
(first use in this function)
  if (err_irq == NO_IRQ) {

This isn't even a PPCism.  It's just wrong.  Compare to zero instead.

-Scott