Re: [PATCH 3/3] printk: implement support for extended console drivers
From: Tejun Heo <tj@kernel.org>
Date: 2015-06-29 16:14:08
Also in:
lkml
From: Tejun Heo <tj@kernel.org>
Date: 2015-06-29 16:14:08
Also in:
lkml
On Mon, Jun 29, 2015 at 06:11:40PM +0200, Geert Uytterhoeven wrote:
On Mon, Jun 29, 2015 at 5:49 PM, Tejun Heo [off-list ref] wrote:quoted
On Mon, Jun 29, 2015 at 05:47:49PM +0200, Geert Uytterhoeven wrote:quoted
quoted
netconsole itself is optional & modular. I'm not sure making further splits is called for, especially given the use cases.It could be a hidden option, selected by its users (e.g. netconsole).Hmmm... what do you mean?init/Kconfig: config PRINTK_EXT_LOG bool drivers/net/Kconfig: config NETCONSOLE tristate "Network console logging support" select PRINTK_EXT_LOG kernel/printk/printk.c: void console_unlock(void) { #ifdef CONFIG_PRINTK_EXT_LOG static char ext_text[CONSOLE_EXT_LOG_MAX]; #endif
OIC, hmmm... yeah, I think doing it on-demand would be better but will try to find out which way is better. Thanks! -- tejun