Re: [PATCH net-next 3/5] bonding: fix incorrect lacp mux state when agg not active

From: Jonathan Toppins <redacted>
Date: Mon, 19 Jan 2015 15:50:48 -0500

On 1/19/15 2:26 PM, Nikolay Aleksandrov wrote:

quoted

quoted

diff --git a/drivers/net/bonding/bond_3ad.c

b/drivers/net/bonding/bond_3ad.c
index e9b706f..52a8772 100644

--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c

@@ -471,10 +471,13 @@ static void __record_pdu(struct lacpdu *lacpdu,

struct port *port)
  		 * and the port is matched
  		 */
  		if ((port->sm_vars & AD_PORT_MATCHED)
-		    && (lacpdu->actor_state & AD_STATE_SYNCHRONIZATION))
+ && (lacpdu->actor_state & AD_STATE_SYNCHRONIZATION)) {

In net/ it's preferred to have the logical operators at the end of the
previous line. It'd be nice if we start fixing these in bond_3ad.c
since
they're being touched by the patch anyhow.

Ack, I prefer at the end too. Question, would it be acceptable to do
the cleanup of the entire bond_3ad.c code in a separate patch? That
way the fix vs. cleanup is clear.

If you're touching this line, fix it's style in-situ.