Re: [PATCH net-next 1/5] bonding: keep bond interface carrier off until at least one active member

On 1/19/15 2:27 PM, Nikolay Aleksandrov wrote:

On 01/16/2015 04:57 PM, Jonathan Toppins wrote:

quoted

diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index 8baa87d..e9b706f 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c

@@ -189,6 +189,7 @@ static inline int __agg_has_partner(struct aggregator *agg)
  static inline void __disable_port(struct port *port)
  {
  	bond_set_slave_inactive_flags(port->slave, BOND_SLAVE_NOTIFY_LATER);
+	bond_3ad_set_carrier(port->slave->bond);
  }

  /**

@@ -199,8 +200,10 @@ static inline void __enable_port(struct port *port)
  {
  	struct slave *slave = port->slave;

-	if ((slave->link == BOND_LINK_UP) && bond_slave_is_up(slave))
+	if ((slave->link == BOND_LINK_UP) && bond_slave_is_up(slave)) {

While at it please remove the extra ( ) around slave->link == BOND_LINK_UP.

Ack.