Thread (59 messages) 59 messages, 9 authors, 2014-12-20

Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks

From: SF Markus Elfring <hidden>
Date: 2014-12-18 17:44:44
Also in: kernel-janitors, lkml

quoted
Now I find still that your data reorgansisation wish can not be resolved
in a simple way.
I'm saying to leave the code alone.
It seems that there might be a misunderstanding between us.

If it goes:

	var = foo_that_returns_ptr_err()
	if (IS_ERR(var))
		return PTR_ERR(var);

	p->bar = var;

or whatever, simply keep it that way!
A simple return was not used by the mppe_alloc() function so far because
a bit of memory clean-up will also be useful after error detection,
won't it?

I'm not engaging in this conversation any further, you have already
consumed way too much of my limited time on this incredibly trivial matter.
It can occasionally happen that a safe clarification of specific implementation
details will need more efforts than you would like to invest at the moment.

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help