Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc()

(off-list ancestor, not in this archive)
[PATCH 0/3] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-11-30
[PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree" · SF Markus Elfring <hidden> · 2014-11-30
Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree" · Sergei Shtylyov <hidden> · 2014-12-01
Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree" · SF Markus Elfring <hidden> · 2014-12-01
Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree" · Sergei Shtylyov <hidden> · 2014-12-01
[PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-12-04
[PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · SF Markus Elfring <hidden> · 2014-12-04
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · Joe Perches <joe@perches.com> · 2014-12-04
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · SF Markus Elfring <hidden> · 2014-12-04
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · Joe Perches <joe@perches.com> · 2014-12-04
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · Julia Lawall <hidden> · 2014-12-05
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · SF Markus Elfring <hidden> · 2014-12-05
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · Julia Lawall <hidden> · 2014-12-05
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · SF Markus Elfring <hidden> · 2014-12-05
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · Joe Perches <joe@perches.com> · 2014-12-05
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · SF Markus Elfring <hidden> · 2014-12-05
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · terry white <hidden> · 2014-12-05
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · Julia Lawall <hidden> · 2014-12-05
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · Joe Perches <joe@perches.com> · 2014-12-05
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · Julia Lawall <hidden> · 2014-12-07
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · Joe Perches <joe@perches.com> · 2014-12-07
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · Julia Lawall <hidden> · 2014-12-07
Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() · Joe Perches <joe@perches.com> · 2014-12-07
[PATCH v2 2/6] net-PPP: Fix indentation · SF Markus Elfring <hidden> · 2014-12-04
[PATCH v2 3/6] net-PPP: Deletion of unnecessary checks before the function call "kfree" · SF Markus Elfring <hidden> · 2014-12-04
[PATCH v2 4/6] net-PPP: Less function calls in mppe_alloc() after error detection · SF Markus Elfring <hidden> · 2014-12-04
[PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc() · SF Markus Elfring <hidden> · 2014-12-04
Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc() · Dan Carpenter <hidden> · 2014-12-05
Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc() · SF Markus Elfring <hidden> · 2014-12-05
Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc() · Dan Carpenter <hidden> · 2014-12-05
Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc() · SF Markus Elfring <hidden> · 2014-12-05
[PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc() · SF Markus Elfring <hidden> · 2014-12-04
Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc() · Dan Carpenter <hidden> · 2014-12-05
Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc() · SF Markus Elfring <hidden> · 2014-12-05
Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc() · Dan Carpenter <hidden> · 2014-12-05
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · David Miller <davem@davemloft.net> · 2014-12-09
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-12-12
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · David Miller <davem@davemloft.net> · 2014-12-12
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-12-12
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · David Miller <davem@davemloft.net> · 2014-12-12
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-12-12
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · David Miller <davem@davemloft.net> · 2014-12-12
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-12-12
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · Eric Dumazet <hidden> · 2014-12-12
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-12-13
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · David Miller <davem@davemloft.net> · 2014-12-12
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-12-13
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-12-18
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · David Miller <davem@davemloft.net> · 2014-12-18
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-12-18
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-12-20
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · Lino Sanfilippo <LinoSanfilippo@gmx.de> · 2014-12-20
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · SF Markus Elfring <hidden> · 2014-12-20
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · David Miller <davem@davemloft.net> · 2014-12-20
Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks · Julia Lawall <hidden> · 2014-12-12
[PATCH 2/3] net-PPP: Less function calls in mppe_alloc() after error detection · SF Markus Elfring <hidden> · 2014-11-30
[PATCH 3/3] net-PPP: Delete an unnecessary assignment · SF Markus Elfring <hidden> · 2014-11-30
Re: [PATCH 3/3] net-PPP: Delete an unnecessary assignment · Eric Dumazet <hidden> · 2014-11-30
Re: [PATCH 3/3] net-PPP: Delete an unnecessary assignment · SF Markus Elfring <hidden> · 2014-11-30

From: Dan Carpenter <hidden>
Date: 2014-12-05 12:23:12
Also in: kernel-janitors, lkml

On Thu, Dec 04, 2014 at 11:18:41PM +0100, SF Markus Elfring wrote:

From: Markus Elfring <redacted>
Date: Thu, 4 Dec 2014 22:33:34 +0100

The data structure element "arc4" was assigned a null pointer by the
mppe_alloc() function if a previous function call "crypto_alloc_blkcipher"
failed.

No.  crypto_alloc_blkcipher() returns error pointers and not NULL.

This patch creates a bug.

regards,
dan carpenter

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help