Thread (59 messages) 59 messages, 9 authors, 2014-12-20

Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks

From: David Miller <davem@davemloft.net>
Date: 2014-12-18 17:26:02
Also in: kernel-janitors, lkml

From: SF Markus Elfring <redacted>
Date: Thu, 18 Dec 2014 18:23:08 +0100
quoted
quoted
Where should "the error pointers" be stored instead?
A local variable, before you assign it into the datastructure.
I have looked at the affected software infrastructure once more.
Now I find still that your data reorgansisation wish can not be resolved
in a simple way.
I'm saying to leave the code alone.

If it goes:

	var = foo_that_returns_ptr_err()
	if (IS_ERR(var))
		return PTR_ERR(var);

	p->bar = var;

or whatever, simply keep it that way!

I'm not engaging in this conversation any further, you have already
consumed way too much of my limited time on this incredibly trivial
matter.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help