Re: [PATCH 2/2] openvswitch: Enable tunnel GSO for OVS bridge.

On Thu, Jun 12, 2014 at 2:27 AM, Or Gerlitz [off-list ref] wrote:

On Sun, May 25, 2014 at 2:39 PM, Pravin B Shelar [off-list ref] wrote:

quoted

Signed-off-by: Pravin B Shelar <redacted>
---
 include/linux/netdev_features.h      | 4 ++++
 net/openvswitch/vport-internal_dev.c | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
index e5a5894..12118a5 100644
--- a/include/linux/netdev_features.h
+++ b/include/linux/netdev_features.h

@@ -152,6 +152,10 @@ enum {
 #define NETIF_F_ALL_FCOE       (NETIF_F_FCOE_CRC | NETIF_F_FCOE_MTU | \
                                 NETIF_F_FSO)

+#define NETIF_F_ALL_ENCAP_GSO   (NETIF_F_GSO_GRE | NETIF_F_GSO_GRE_CSUM | \
+                                NETIF_F_GSO_IPIP | NETIF_F_GSO_SIT |     \
+                                NETIF_F_GSO_UDP_TUNNEL | NETIF_F_GSO_MPLS)
+
 /*
  * If one device supports one of these features, then enable them
  * for all in netdev_increment_features.

diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
index 789af92..b971610 100644
--- a/net/openvswitch/vport-internal_dev.c
+++ b/net/openvswitch/vport-internal_dev.c

@@ -134,7 +134,8 @@ static void do_setup(struct net_device *netdev)
        netdev->tx_queue_len = 0;

        netdev->features = NETIF_F_LLTX | NETIF_F_SG | NETIF_F_FRAGLIST |
-                          NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_GSO_SOFTWARE;
+                          NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_GSO_SOFTWARE |
+                          NETIF_F_ALL_ENCAP_GSO;

        netdev->vlan_features = netdev->features;
        netdev->features |= NETIF_F_HW_VLAN_CTAG_TX;

OK, I guess this commit is similar in spirit to 82d8189 "veth: extend
features to support tunneling"

So in that respect, don't you need to set also dev->hw_enc_features
for the NETIF_F_GSO_YYY to come into play?

Right, I will send updated patch.