Re: [PATCH 2/2] openvswitch: Enable tunnel GSO for OVS bridge.
From: Or Gerlitz <hidden>
Date: 2014-06-11 09:26:19
On Sun, May 25, 2014 at 2:39 PM, Pravin B Shelar [off-list ref] wrote:
Signed-off-by: Pravin B Shelar <redacted>
Hi Pravin, Can you please provide a non-empty change log for this patch... I understand the patch addresses some openvswitch use case where offloads are currently non-coming into play and you want to support that, right?
quoted hunk ↗ jump to hunk
+++ b/include/linux/netdev_features.h@@ -152,6 +152,10 @@ enum { #define NETIF_F_ALL_FCOE (NETIF_F_FCOE_CRC | NETIF_F_FCOE_MTU | \ NETIF_F_FSO) +#define NETIF_F_ALL_ENCAP_GSO (NETIF_F_GSO_GRE | NETIF_F_GSO_GRE_CSUM | \ + NETIF_F_GSO_IPIP | NETIF_F_GSO_SIT | \ + NETIF_F_GSO_UDP_TUNNEL | NETIF_F_GSO_MPLS)
AFAIK OVS supports only VXLAN and GRE tunneling -- wouldn't it be enough to add here only NETIF_F_GSO_GRE and NETIF_F_GSO_UDP_TUNNEL?
quoted hunk ↗ jump to hunk
+ /* * If one device supports one of these features, then enable them * for all in netdev_increment_features.diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index 789af92..b971610 100644 --- a/net/openvswitch/vport-internal_dev.c +++ b/net/openvswitch/vport-internal_dev.c@@ -134,7 +134,8 @@ static void do_setup(struct net_device *netdev) netdev->tx_queue_len = 0; netdev->features = NETIF_F_LLTX | NETIF_F_SG | NETIF_F_FRAGLIST | - NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_GSO_SOFTWARE; + NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_GSO_SOFTWARE | + NETIF_F_ALL_ENCAP_GSO; netdev->vlan_features = netdev->features; netdev->features |= NETIF_F_HW_VLAN_CTAG_TX;