RE: [net-next 05/13] igb: Add support for debugfs

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Wednesday, March 12, 2014 1:24 PM
To: Wyborny, Carolyn
Cc: or.gerlitz@gmail.com; Kirsher, Jeffrey T; gospo@redhat.com;
netdev@vger.kernel.org; sassmann@redhat.com; hayja@mail.uc.edu;
amirv@mellanox.com; yevgenyp@mellanox.com
Subject: Re: [net-next 05/13] igb: Add support for debugfs

From: "Wyborny, Carolyn" <redacted>
Date: Wed, 12 Mar 2014 20:13:53 +0000

quoted

quoted

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Wednesday, March 12, 2014 12:47 PM
To: Wyborny, Carolyn
Cc: or.gerlitz@gmail.com; Kirsher, Jeffrey T; gospo@redhat.com;
netdev@vger.kernel.org; sassmann@redhat.com; hayja@mail.uc.edu;
amirv@mellanox.com; yevgenyp@mellanox.com
Subject: Re: [net-next 05/13] igb: Add support for debugfs

From: "Wyborny, Carolyn" <redacted>
Date: Wed, 12 Mar 2014 16:35:49 +0000

quoted

Josh and I tried very hard to not reimplement anything already
available in some other tool or mechanism and used the examples we
already have for this in our other drivers.  That being said, we'll
abide and follow any clear criteria provided.

I don't think what's being done here is appropriate.

ethtool can provide the extended statistics.

We already have a way to dump registers in ethtool as well.  If you
want to add fine-grained register read support and write support,
that would be a nice addition to ethtool.

Ok, I'll remove the register outputs.  Is there any objection to the other

functionality provided?

I said the statistics can be done with ethtool, so I object to everything.

Understood.  Withdrawing patchset.  Will take suggestion for ethtool work.