Re: [net-next 12/13] ixgbe: fix some multiline hw_dbg prints

On Wed, 2014-03-12 at 23:24 +0300, Sergei Shtylyov wrote:

On 03/12/2014 11:11 PM, Sergei Shtylyov wrote:

quoted

quoted

quoted

quoted

From: Jacob Keller <jacob.e.keller@intel.com>

quoted

quoted

quoted

quoted

This patch fixes some formatting on multilined print messages, so that
the text of the print appears on a single line, which aids in grepping
the sourcecode for where the error came from.

quoted

quoted

quoted

quoted

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Phil Schmitt <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
   drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 8 +++-----
   1 file changed, 3 insertions(+), 5 deletions(-)

quoted

quoted

quoted

quoted

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c

b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
index 446df3c..3bc9b67 100644

--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c

@@ -512,7 +512,7 @@ out:
    *
    * Disables link, should be called during D3 power down sequence.
    *
- */
+ **/

quoted

quoted

quoted

     Hm? What's this for?

quoted

quoted

The extra **/ is part of the standard doc format for function headers,

quoted

    It is not. Reread Documentation/kernel-doc-nano-HOWTO.txt please.

    Sorry, I messed it myself -- it seems to be an optional part of the format 
which I've never seen actually used. Anyway, you shouldn't do "drove-by" 
changes like that, moreover undocumented in the change log.

WBR, Sergei

It's used all over in our driver source, and I was trying to sync style.
But I can re-spin this patch with that hunk dropped.

Thanks,
Jake